fix(tests): fix the pollingInterval test #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why this test started failing recently, but it's failing in main and PR branches in Node 18 and 20 (but not 16 for some reason). fastify is supposed to close idle connections when `close()` is called, but it's not doing that in the test for some unknown reason. Setting `forceCloseConnections: true` makes fastify forcibly close the sockets and shutdown even if the sockets aren't idle, which seems fine for this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this test started failing recently, but it's failing in main and PR branches in Node 18 and 20 (but not 16 for some reason). fastify is supposed to close idle connections when
close()is called, but it's not doing that in the test for some unknown reason. SettingforceCloseConnections: truemakes fastify forcibly close the sockets and shutdown even if the sockets aren't idle, which seems fine for this test.