-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize GitHub action shell cmd to prevent cmd injection #3509 #3510
Merged
hamidonos
merged 21 commits into
develop
from
gha_feature-sanitize-github-action-shell-cmd-to-prevent-cmd-injection-#3509
Oct 17, 2024
Merged
Sanitize GitHub action shell cmd to prevent cmd injection #3509 #3510
hamidonos
merged 21 commits into
develop
from
gha_feature-sanitize-github-action-shell-cmd-to-prevent-cmd-injection-#3509
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-jcup
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work - let's merge it 👍
hamidonos
deleted the
gha_feature-sanitize-github-action-shell-cmd-to-prevent-cmd-injection-#3509
branch
October 17, 2024 06:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
We use
execFileSync
to execute shell commands in a a separate child process.Separate Process:
The child process created by execFileSync runs independently from the main Node.js process. It does not share the same memory or execution context with the parent process, so they do not interfere with each other directly.
If the child process crashes or exits, it won't directly crash the parent Node.js process.
Controlled Input and Output:
The child process has its own stdin, stdout, and stderr streams, and the parent process can choose to interact with them (read/write), but they are isolated unless explicitly connected.
By default, execFileSync captures the output of the child process and returns it to the parent process only after execution completes.
Environment Variables:
The child process runs with its own set of environment variables. You can specify a custom environment for the child process, which is separate from the environment of the parent process.
Every argument is passed separately.
Every shell argument is sanitized independently
Before we pass shell commands and arguments to the child process we sanitize the input parameters.
Sanitization checks for illegal characters and if a argument is a executable command -> if so we throw an error and exit the program