Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature implement o auth for sec hub web UI #3406 #3473

Merged
merged 22 commits into from
Oct 10, 2024
Merged

Feature implement o auth for sec hub web UI #3406 #3473

merged 22 commits into from
Oct 10, 2024

Conversation

hamidonos
Copy link
Collaborator

@hamidonos hamidonos commented Sep 30, 2024 •
edited
Loading

@hamidonos
add spring security with oauth to web ui
8ed9b3a
@hamidonos
implement pull request workflow for gha action and gradle action #3357
6f9ec88
@hamidonos
add mb sso to application.yml
4c2c51b
@hamidonos
implement oauth config for sechub webui #3406
8ff490b
@hamidonos
make web ui spring security oidc config configurable through env vari…
3cb3e4a 
…ables #3406
@hamidonos
change variable names in application-webui_oidc.yaml
534d3d1
@hamidonos
Merge branch 'refs/heads/develop' into feature-Implement-OAuth-for-Se…
0044d27 
…cHub-WebUI-#3406
@hamidonos
remove webflux from web ui project
c6d727f
@hamidonos
implement success handler for redirect after successful o auth workfl…
a0fcb54 
…ow in web ui
@hamidonos
add basic and form login to spring security in web ui
e5bb330
@hamidonos
add under construction site to web ui
d40d1e0
@hamidonos
set default page to /home in webui
84a874b
@hamidonos
Merge branch 'refs/heads/develop' into feature-Implement-OAuth-for-Se…
8eb1ab1 
…cHub-WebUI-#3406
@hamidonos
update README.md in web ui
df3b83d
@hamidonos
clean up build.gradle of webui
716daff
@hamidonos
fix formatting in MercedesBenzOAuth2AccessTokenClient
7e92270
@de-jcup de-jcup self-requested a review October 1, 2024 10:17
de-jcup
de-jcup requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@de-jcup de-jcup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job - but I still found some parts I want to discuss/to be changed.

...rc/main/java/com/mercedesbenz/sechub/webui/security/MercedesBenzOAuth2AccessTokenClient.java Outdated Show resolved Hide resolved
sechub-webui-solution/helm/sechub-webui/values.yaml Show resolved Hide resolved
sechub-webui/README.md Outdated Show resolved Hide resolved
sechub-webui/build.gradle Outdated Show resolved Hide resolved
sechub-webui/src/main/java/com/mercedesbenz/sechub/webui/credentials/NewApiTokenController.java Show resolved Hide resolved
sechub-webui/src/test/java/com/mercedesbenz/sechub/webui/YamlPropertyLoaderFactory.java Show resolved Hide resolved
sechub-webui/src/test/java/com/mercedesbenz/sechub/webui/YamlPropertyLoaderFactory.java Show resolved Hide resolved
sechub-webui/src/test/java/com/mercedesbenz/sechub/webui/page/LoginClassicControllerTest.java Show resolved Hide resolved
sechub-webui/src/test/java/com/mercedesbenz/sechub/webui/page/LoginOAuth2ControllerTest.java Show resolved Hide resolved
...desbenz/sechub/webui/security/Base64EncodedClientIdAndSecretOAuth2AccessTokenClientTest.java Outdated Show resolved Hide resolved
de-jcup
de-jcup approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@de-jcup de-jcup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job - I found 2 minor things, but I think it is up to you if you change it or not.

.../src/main/java/com/mercedesbenz/sechub/webui/security/LoginAuthenticationSuccessHandler.java Outdated Show resolved Hide resolved
sechub-webui/src/main/resources/application.yml Outdated Show resolved Hide resolved
@hamidonos hamidonos merged commit 1b3891d into develop Oct 10, 2024
2 checks passed
@hamidonos hamidonos deleted the feature-Implement-OAuth-for-SecHub-WebUI-#3406 branch October 10, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de-jcup de-jcup de-jcup approved these changes

Assignees

@de-jcup de-jcup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement OAuth2 for WebUI Application
2 participants
@hamidonos @de-jcup