Apply spotless #837

mercedes-benz · May 7, 2024 · e489658 · e489658
1 parent d581297
commit e489658
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/...re/src/main/java/com/mercedesbenz/sechub/commons/core/security/persistence/AesGcmSiv.java b/...re/src/main/java/com/mercedesbenz/sechub/commons/core/security/persistence/AesGcmSiv.java
@@ -29,7 +29,6 @@
  */
 public class AesGcmSiv implements PersistenceCipher {
 
-    // TODO: Encrypt secret?
     private SecretKey secret;
     private Provider cryptoProvider;
     private PersistenceCipherType cipherType;
@@ -66,7 +65,7 @@ public static AesGcmSiv create(BinaryString secret) throws InvalidKeyException {
 
             instance = new AesGcmSiv(secretKey, cipherType);
         } else {
-            throw new InvalidKeyException("The secret has to be 128, 192 or 256 bits long, but was " + (rawSecret.length * 8) + " bits long.");
+            throw new InvalidKeyException("The secret has to be 128 or 256 bits long, but was " + (rawSecret.length * 8) + " bits long.");
         }
 
         return instance;

diff --git a/...n/java/com/mercedesbenz/sechub/commons/core/security/persistence/BinaryStringFactory.java b/...n/java/com/mercedesbenz/sechub/commons/core/security/persistence/BinaryStringFactory.java
@@ -52,7 +52,7 @@ public static BinaryString createFromBytes(byte[] bytes, BinaryStringEncodingTyp
      * @return
      */
     public static BinaryString createFromString(String string) {
-        return createFromString(string, BinaryStringEncodingType.BASE64);
+        return createFromString(string, DEFAULT_ENCODING_TYPE);
     }
 
     /**

diff --git a/...main/java/com/mercedesbenz/sechub/commons/core/security/persistence/RotationStrategy.java b/...main/java/com/mercedesbenz/sechub/commons/core/security/persistence/RotationStrategy.java
@@ -193,6 +193,6 @@ public boolean isSecretRotationStrategy() {
     }
 
     public boolean isCipherRotationStrategy() {
-        return (currentCipher.getCipherType() != newCipher.getCipherType()) ? true : false;
+        return currentCipher.getCipherType() != newCipher.getCipherType();
     }
 }
diff --git a/...rc/test/java/com/mercedesbenz/sechub/commons/core/security/persistence/AesGcmSivTest.java b/...rc/test/java/com/mercedesbenz/sechub/commons/core/security/persistence/AesGcmSivTest.java
@@ -194,7 +194,7 @@ void encrypt__aes_256_hex_format_and_emojis() throws InvalidKeyException, Invali
     void encrypt__aes_128_base64_format_and_emojis() throws InvalidKeyException, InvalidAlgorithmParameterException {
         /* prepare */
         BinaryString secret = new Base64String("🍐🍌🍓🍉");
-        ;
+
         String plaintext = "Hello 👋, welcome to 🌐.";
         String expectedCiphertext = "Qu7ICJBGMw9dAPPBWx86e5bjOq3YKC+x25n/YkluWZAGdSna08tKaE78pMk=";
         BinaryString initializationVector = new Base64String("🧅".repeat(AesGcmSiv.IV_LENGTH_IN_BYTES / 4));