Skip to content

[2962](Feature): 3DS agnostic implementation #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

[2962](Feature): 3DS agnostic implementation #65

wants to merge 47 commits into from

Conversation

@capaixao
Copy link
Collaborator

@capaixao capaixao commented Jul 25, 2025 •
edited
Loading

Pull Request

3DS agnostic implementation

Ticket or Issue link

2962

Description

Implement agnostic 3DS authentication module

  • Add MPThreeDS main class with initialize() and requestChallenge() methods
  • Create complete dependency injection structure with MPThreeDSModulesProvider
  • Implement domain models (MPThreeDSAuthenticationResponse, ThreeDSBody, ThreeDSAuthRequestParameters)
  • Add MPThreeDSChallengeDelegate interface for authentication callbacks
  • Create agnostic ThreeDSSDKAdapter interface with default mock implementation
  • Implement repository pattern with ThreeDSRepository and remote data source
  • Add AuthenticateUseCase and RequestChallengeUseCase for business logic
  • Create Retrofit service for MercadoPago backend authentication API
  • Add MercadoPagoSDK.threeDS extension property for easy access
  • Implement error handling with MPThreeDSChallengeError and custom exceptions
  • Support multiple directory servers (VISA, Mastercard, AMEX)
  • Follow complete sequence diagram flow for 3DS authentication process

Checklist

  • I have tested my changes creating a local version (More info in README file).
  • I have added tests that prove my solution is effective and works
  • New and existing unit tests pass locally with my changes.
  • Verify that you are merged with the latest in develop.
  • I have run ./gradlew check and fixed any possible issues of my code.
  • I have tested my changes with configuration changes such as rotation, no conection, framework error handling
  • I have tested the accessibility of the changes and added them to the screenshots.
  • I have added a tag to the pull request that contains the product this pull request is related to.

Screenshots or videos (if applies)

capaixao added 9 commits July 23, 2025 16:55
@capaixao
feature: creating 3ds
8e4f337
@capaixao
feature: implement agnostic 3DS authentication module
f805c12 
- Add MPThreeDS main class with initialize() and requestChallenge() methods
- Create complete dependency injection structure with MPThreeDSModulesProvider
- Implement domain models (MPThreeDSAuthenticationResponse, ThreeDSBody, ThreeDSAuthRequestParameters)
- Add MPThreeDSChallengeDelegate interface for authentication callbacks
- Create agnostic ThreeDSSDKAdapter interface with default mock implementation
- Implement repository pattern with ThreeDSRepository and remote data source
- Add AuthenticateUseCase and RequestChallengeUseCase for business logic
- Create Retrofit service for MercadoPago backend authentication API
- Add MercadoPagoSDK.threeDS extension property for easy access
- Implement error handling with MPThreeDSChallengeError and custom exceptions
- Support multiple directory servers (VISA, Mastercard, AMEX)
- Follow complete sequence diagram flow for 3DS authentication process
@capaixao
feature: adjusted ktlint
093f983
@capaixao
feature: adjustments in provider and challenge error
21609ec
@capaixao
feature: adjust mock call response
765b769
@capaixao
feature: remove compose in 3ds module
99976b8
@capaixao
feature: changed implementation with master card sdk
a58786d
@capaixao
feature: added gradle config
3af0192
@capaixao
feature: commit
8e01a84
@capaixao capaixao self-assigned this Jul 25, 2025
@capaixao capaixao changed the title [2962](Feature): Checkout implementation [2962](Feature): Checkout agnostic implementation Jul 25, 2025
@capaixao capaixao changed the title [2962](Feature): Checkout agnostic implementation WIP: [2962](Feature): Checkout agnostic implementation Jul 25, 2025
@capaixao capaixao added the feature New feature or request label Jul 25, 2025
@capaixao capaixao changed the title WIP: [2962](Feature): Checkout agnostic implementation [2962](Feature): Checkout agnostic implementation Jul 28, 2025
@capaixao capaixao changed the title [2962](Feature): Checkout agnostic implementation WIP: [2962](Feature): Checkout agnostic implementation Jul 29, 2025
@capaixao capaixao changed the title WIP: [2962](Feature): Checkout agnostic implementation WIP: [2962](Feature): 3DS agnostic implementation Jul 29, 2025
@capaixao
feature: changed test case
34cb993
@capaixao
Merge branch 'main' into feature/2962/checkout-implementation
ded6d65 
# Conflicts:
#	components/src/main/java/com/mercadopago/sdk/android/components/MPText.kt
#	threeds/build.gradle.kts
samantaalbanez
samantaalbanez reviewed Sep 23, 2025
View reviewed changes
Copy link
Collaborator

@samantaalbanez samantaalbanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

@capaixao capaixao changed the title WIP: [2962](Feature): 3DS agnostic implementation [2962](Feature): 3DS agnostic implementation Nov 5, 2025
francineemilia
francineemilia previously approved these changes Nov 13, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francineemilia francineemilia francineemilia left review comments

@samantaalbanez samantaalbanez Awaiting requested review from samantaalbanez

At least 2 approving reviews are required to merge this pull request.

Assignees

@capaixao capaixao

Labels

feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@capaixao @francineemilia @samantaalbanez