Deprecate comment_name_list from db - #63
Merged
merces merged 1 commit intoAug 23, 2026
Merged
Conversation
This was referenced Aug 16, 2026
Merged
Member
|
This is great! Thanks for your help with this!
Agreed. :)
Perfect! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A followup from #59
There we separate hex_view from the database,
here we stop serializing comment_name_list to the database, since it can be recovered from comments map only.
Old database files can still be read by newer version of the cli, but newer DBs will not be able to be read by older cli versions.
I think this is an OK trade-off, people wont loose their work when upgrading (since they can still read it with the newer version)
and if they receive a db from someone that has a newer version (I don't imagine this being common), they can just update their CLI to read the file.