Merge pull request neovim#14607 from glacambre/fix_get_all_options_in…

…fo_crash [RDY] Generate PARAM_COUNT macro
mengtanhzc · May 26, 2021 · 0b905be · 0b905be
2 parents fd91e73 + 0c8454f
commit 0b905be
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/nvim/option.c b/src/nvim/option.c
@@ -7705,7 +7705,7 @@ Dictionary get_vimoption(String name, Error *err)
 Dictionary get_all_vimoptions(void)
 {
   Dictionary retval = ARRAY_DICT_INIT;
-  for (size_t i = 0; i < PARAM_COUNT; i++) {
+  for (size_t i = 0; options[i].fullname != NULL; i++) {
     Dictionary opt_dict = vimoption2dict(&options[i]);
     PUT(retval, options[i].fullname, DICTIONARY_OBJ(opt_dict));
   }

diff --git a/test/functional/api/vim_spec.lua b/test/functional/api/vim_spec.lua
@@ -1986,6 +1986,10 @@ describe('API', function()
 
       eq(meths.get_option_info'winhighlight', options_info.winhighlight)
     end)
+
+    it('should not crash when echoed', function()
+      meths.exec("echo nvim_get_all_options_info()", true)
+    end)
   end)
 
   describe('nvim_get_option_info', function()