Skip to content

Commit

Permalink
fix IE bug by removing multiple define of chartoptions.animation in p…
Browse files Browse the repository at this point in the history
…ie chart and doughnut chart
  • Loading branch information
cdcharlebois committed Nov 20, 2017
1 parent 8d33efb commit c15c379
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
8 changes: 3 additions & 5 deletions src/ChartJS/widgets/DoughnutChart/widget/DoughnutChart.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,15 @@ define([
animateScale: this.animateScale,
duration: this.animationDuration,
//String - Animation easing effect
easing: this.animationEasing
easing: this.animationEasing,
onComplete: lang.hitch(this, this._animationComplete)
},

legendCallback: this._legendAlternateCallback,

//Number - The percentage of the chart that we cut out of the middle
cutoutPercentage: this.percentageInnerCutout,

animation: {
onComplete: lang.hitch(this, this._animationComplete)
}
})
});

Expand All @@ -121,4 +119,4 @@ define([
});
});

require(["ChartJS/widgets/DoughnutChart/widget/DoughnutChart"]);
require(["ChartJS/widgets/DoughnutChart/widget/DoughnutChart"]);
8 changes: 3 additions & 5 deletions src/ChartJS/widgets/PieChart/widget/PieChart.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,17 +94,15 @@ define([
animateScale: this.animateScale,
duration: this.animationDuration,
//String - Animation easing effect
easing: this.animationEasing
easing: this.animationEasing,
onComplete: lang.hitch(this, this._animationComplete)
},

legendCallback: this._legendAlternateCallback,

//cutOut of pie
cutoutPercentage: 0, //always zero for Pie chart

animation: {
onComplete: lang.hitch(this, this._animationComplete)
}
})
};
this._chart = new this._chartJS(this._ctx, chartProperties);
Expand All @@ -123,4 +121,4 @@ define([
});
});

require(["ChartJS/widgets/PieChart/widget/PieChart"]);
require(["ChartJS/widgets/PieChart/widget/PieChart"]);
Binary file modified test/widgets/ChartJS.mpk
Binary file not shown.

0 comments on commit c15c379

Please sign in to comment.