[WC-3279] Datagrid 2: Enforce filter-aware minimum width during column resize#2104
Open
rahmanunver wants to merge 2 commits intomainfrom
Open
[WC-3279] Datagrid 2: Enforce filter-aware minimum width during column resize#2104rahmanunver wants to merge 2 commits intomainfrom
rahmanunver wants to merge 2 commits intomainfrom
Conversation
rahmanunver
force-pushed
the
wc-3279_dg2_column_resize
branch
from
cc0909d to
ead3225
Compare
rahmanunver
force-pushed
the
wc-3279_dg2_column_resize
branch
from
5b03eb3 to
7988b24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Columns could be resized narrower than their header filter widget required, making filters unusable or invisible. The hardcoded 50px minimum in
ColumnResizerpredates the dual-grid architecture introduced in 3.8.0, where the body grid independently determines column widths, meaning the header filter content could be resized however wished.What should be covered while testing?