[RFC] Go support changes #382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 25, 2017 21:29
The current poky creates a symlink for src pointing at the original location such that when we try to rsync we end up deleting both the original and the new. Changelog: Title Signed-off-by: Drew Moseley <drew.moseley@northern.tech>
…y changes. Yocto's golang support has changed so that the src directories are no longer correct. Use the new full paths. Changelog: Title Signed-off-by: Drew Moseley <drew.moseley@northern.tech>
Changelog: Title Signed-off-by: Drew Moseley <drew.moseley@northern.tech>
|
Hmm, I think the rsync could be removed completely actually, since they now point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed these changes to get a master-based build to succeed. I did see at least one relevant change in poky (https://git.yoctoproject.org/cgit.cgi/poky/commit/?id=07ef4dd93dcb21418647932f3324ee09bc514895) that would require some of this. I didn't dig too deeply and these are likely not the best solution but I needed something that would build.
Any idea what the right fix is for these?