Smaller fixes to support upcoming commits #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changelog needed, because `resume` has not been released yet. Changelog: None Ticket: None Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
This was my own mistake, but it's an easy one to make. `CmdlineOptionsIterator` takes two arguments, options with values, and options without values. However the two functions `CommandOptsSetWithValue` and `CommandOptsSetWithoutValue` will filter and construct the correct lists from one single list of options, but it's easy to conclude that the options need to be kept in separate lists. This was made even more confusing by the call sites not passing in this one list consistently, but instead passing it in depending on whether that particular command has arguments or not. This is not necessary, since the two aforementioned functions would automagically construct the correct (empty) lists based on filtering. Simplify this, and give the constructor one argument instead, the full list of options, and then it can itself do the filtering, so that it doesn't look like we are using two different lists from call sites. This removes the need for the `options_w_values` list. Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
|
@kacf, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". my commands and optionsYou can trigger a pipeline on multiple prs with:
You can start a fast pipeline, disabling full integration tests with:
You can trigger GitHub->GitLab branch sync with:
You can cherry pick to a given branch or branches with:
|
lluiscampos
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.