chore: Don't duplicate DefaultPaths in every source file.
#1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simple change saves more than 12K in the final binary. For future reference, using `readelf -s` to look for duplicate symbols is a useful way to hunt for such space waste. I haven't looked deeply at it, but starting by looking in object files for duplicated `LOCAL` symbols without `WEAK` is a good beginning. I just found this one randomly though, and I cannot dive deeper into this rabbit hole now. Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
|
@kacf, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". my commands and optionsYou can trigger a pipeline on multiple prs with:
You can start a fast pipeline, disabling full integration tests with:
You can trigger GitHub->GitLab branch sync with:
You can cherry pick to a given branch or branches with:
|
lluiscampos
approved these changes
Aug 27, 2024
|
Hello 😺 This PR contains changelog entries. Please, verify the need of backporting it to the following release branches: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple change saves more than 12K in the final binary.
For future reference, using
readelf -sto look for duplicate symbols is a useful way to hunt for such space waste. I haven't looked deeply at it, but starting by looking in object files for duplicatedLOCALsymbols withoutWEAKis a good beginning. I just found this one randomly though, and I cannot dive deeper into this rabbit hole now.