fix: Progress reader updates the output only when progressing

Due to a bug in the logic, the progress was being updated after every block, even if the percentage number was not changing. This made the reading/writing of Artifacts slow and noisy. Changelog: Title Ticket: MEN-7159 Signed-off-by: Lluis Campos <lluis.campos@northern.tech>
mendersoftware · Aug 26, 2024 · 23d2616 · 23d2616
1 parent eae7540
commit 23d2616
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/mender-update/progress_reader/progress_reader.cpp b/src/mender-update/progress_reader/progress_reader.cpp
@@ -30,6 +30,7 @@ expected::ExpectedSize Reader::Read(
 		int percentage = (bytes_read_ / static_cast<float>(tot_size_)) * 100;
 		if (percentage > last_percentage) {
 			cerr << "\r" << percentage << "%";
+			last_percentage = percentage;
 		}
 	}
 	return exp_read;

diff --git a/tests/src/mender-update/progress_reader/progress_reader_test.cpp b/tests/src/mender-update/progress_reader/progress_reader_test.cpp
@@ -63,5 +63,5 @@ TEST(ProgressReaderTests, RegularRead) {
 
 	std::string output = testing::internal::GetCapturedStderr();
 
-	EXPECT_EQ(output, "\r0%\r5%\r5%\r25%\r90%\r100%");
+	EXPECT_EQ(output, "\r0%\r5%\r25%\r90%\r100%");
 }