Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notion): add data provider #10

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

mogery
Copy link
Member

@mogery mogery commented Jan 30, 2024

Fixes #8
/claim #8

Retrieves all (accessible) pages from a Notion workspace, including nested pages in databases, like described in #8. Converts the page contents to Markdown. I brought my own Markdown converter, reads a bit dodgy, but works just fine (not my first time doing that lol). No huge dependencies either :D

Linked the GIF I sent to #8 as access granting instructions in the README.

@mogery
Copy link
Member Author

mogery commented Jan 30, 2024

Note: Doing an npm run format changes like half the files in the repo. I only committed the notion-related changes of it because I didn't want to cause conflict, but maybe it's time to enforce formatting via an action.

@nickscamara
Copy link
Member

Sounds good!

I will review this as soon as I get a chance! Thanks again @mogery

Ps. if you want to attempt #5 also, feel free to :)

@mogery
Copy link
Member Author

mogery commented Jan 30, 2024

Ps. if you want to attempt #5 also, feel free to :)

Time's a little tight, I'll see how I get on with the other stuff I gotta do. I'll check back in tomorrow wrt that.

@nickscamara
Copy link
Member

/tip $10

Copy link

algora-pbc bot commented Jan 30, 2024

Copy link

algora-pbc bot commented Jan 30, 2024

🎉🎈 @mogery has been awarded $10! 🎈🎊

@nickscamara nickscamara merged commit 2ac0c55 into mendableai:main Jan 30, 2024
@mogery mogery deleted the mog/notion branch January 30, 2024 21:20
@mogery
Copy link
Member Author

mogery commented Jan 30, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Notion Data Connector
2 participants