Skip to content

Conversation

kkysen
Copy link
Collaborator

@kkysen kkysen commented Oct 31, 2024

I think most frames should be the same size, so hopefully this helps enough without having to have a whole pool allocator, which gets tricky with lifetimes and self-referential structs.

@ivanloz, could you look at this version, too? Since this one doesn't use any unstable features.

@ivanloz
Copy link

ivanloz commented Oct 31, 2024

I mentioned it in #1358 (comment), but I didn't see any difference with this patch applied unfortunately.

@fbossen
Copy link
Collaborator

fbossen commented Apr 25, 2025

Isn't the memory released anyway at the end of each frame in rav1d_decode_frame_exit (see let _ = mem::take(&mut f.mvs)) and therefore reallocated in rav1d_submit_frame?

@kkysen
Copy link
Collaborator Author

kkysen commented Apr 25, 2025

Isn't the memory released anyway at the end of each frame in rav1d_decode_frame_exit (see let _ = mem::take(&mut f.mvs)) and therefore reallocated in rav1d_submit_frame?

Hmm, I didn't think of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants