Skip to content

struct {Rav1dContext,TaskThreadDataDelayedFg}: Remove TODOed unsafe impl Send + Syncs #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: kkysen/Rav1dPictureDataComponentInner-ptr-Unique
Choose a base branch
from
Open

struct {Rav1dContext,TaskThreadDataDelayedFg}: Remove TODOed unsafe impl Send + Syncs #1329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/internal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,11 +304,6 @@ pub(crate) struct TaskThreadDataDelayedFg {
pub grain: Grain,
}

// TODO(SJC): Remove when TaskThreadDataDelayedFg is thread-safe
unsafe impl Send for TaskThreadDataDelayedFg {}
// TODO(SJC): Remove when TaskThreadDataDelayedFg is thread-safe
unsafe impl Sync for TaskThreadDataDelayedFg {}

#[derive(Default)]
#[repr(C)]
pub(crate) struct TaskThreadData {
Expand Down Expand Up @@ -436,11 +431,6 @@ pub struct Rav1dContext {
pub(crate) picture_pool: Arc<MemPool<u8>>,
}

// TODO(SJC): Remove when Rav1dContext is thread-safe
unsafe impl Send for Rav1dContext {}
// TODO(SJC): Remove when Rav1dContext is thread-safe
unsafe impl Sync for Rav1dContext {}

#[derive(Default)]
#[repr(C)]
pub struct Rav1dTask {
Expand Down
Loading