Skip to content

Conversation

@seuros
Copy link
Contributor

@seuros seuros commented Nov 14, 2025

  • upgrade to edition 2024 with explicit unsafe blocks
  • update bindgen to 0.72, no need to use ngihtly
  • update dependencies
  • add reference counting for mg_init/mg_finalize lifecycle
  • fix trust callback use-after-free vulnerability
  • fix non-NUL-terminated string in pull()
  • fix parameter map memory leaks in execute()
  • fix lazy fetch ignoring has_more flag
  • add NULL pointer checks for mg_make allocations
  • compute timezone offset from IANA timezone instead of hard-coding to 0
  • replace MgError with thiserror-based enum
  • removed levacy .unwrap() calls with proper error propagation
  • eliminate str_to_c_str memory leak
  • fix all clippy warnings
  • fix Point3D Display label

While this look likes lot of work, most of the changes are warning in rust check/clippy.

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2025

CLA assistant check
All committers have signed the CLA.

@antejavor antejavor self-assigned this Nov 14, 2025
@antejavor antejavor added the bug Something isn't working label Nov 14, 2025
Copy link
Collaborator

@antejavor antejavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to fix the CI first before merging this, only the Ubuntu build is failing because we currently run tests just for the Linux.

@seuros
Copy link
Contributor Author

seuros commented Nov 17, 2025

That a flaky ci. you can rebuild it.

You can see that the new commit that broke it, just removed auto generated text.

The build is green as in the previous tests.

I can't restart the build from my side.

Let me force push

@antejavor
Copy link
Collaborator

antejavor commented Nov 17, 2025

Yeah, haven't looked at the details, but it looks like some random checks are failing, looks flaky, will look into more details later today.

@seuros seuros force-pushed the master branch 2 times, most recently from c013bd7 to 34a51cc Compare November 17, 2025 20:03
@seuros
Copy link
Contributor Author

seuros commented Nov 17, 2025

I fixed the assertion with the latest version of memgraph.

The upgrade also fixed the compilation in Apple Silicon.

@antejavor
Copy link
Collaborator

You can ignore the CentOS build, I will take a look at that @seuros, and review this probably tomorrow.

@seuros
Copy link
Contributor Author

seuros commented Nov 18, 2025

The PR can be merged.

Centos is broken because it deprecated , it don't have the new git 2.18 required.

There is no reason to test in centos, it the same binary as ubuntu.

Copy link
Collaborator

@antejavor antejavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move forward with this. It looks good.

@antejavor antejavor merged commit c7db486 into memgraph:master Nov 19, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants