-
Notifications
You must be signed in to change notification settings - Fork 11
feat: modernize to Rust edition 2024 #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
antejavor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to fix the CI first before merging this, only the Ubuntu build is failing because we currently run tests just for the Linux.
|
That a flaky ci. you can rebuild it. You can see that the new commit that broke it, just removed auto generated text. The build is green as in the previous tests. I can't restart the build from my side. Let me force push |
|
Yeah, haven't looked at the details, but it looks like some random checks are failing, looks flaky, will look into more details later today. |
c013bd7 to
34a51cc
Compare
|
I fixed the assertion with the latest version of memgraph. The upgrade also fixed the compilation in Apple Silicon. |
|
You can ignore the CentOS build, I will take a look at that @seuros, and review this probably tomorrow. |
|
The PR can be merged. Centos is broken because it deprecated , it don't have the new git 2.18 required. There is no reason to test in centos, it the same binary as ubuntu. |
antejavor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move forward with this. It looks good.
While this look likes lot of work, most of the changes are warning in rust check/clippy.