Skip to content

Add rewrite for planning inside OPTIONAL #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Josipmrden merged 11 commits into from
Mar 4, 2025
Merged

Add rewrite for planning inside OPTIONAL #2741

Josipmrden merged 11 commits into from
Mar 4, 2025

Conversation

@Josipmrden
Copy link
Contributor

@Josipmrden Josipmrden commented Feb 25, 2025

Valid plans are rejected if they use edge indices inside optional

@Josipmrden
Copy link
Contributor Author

Josipmrden commented Feb 25, 2025 •
edited
Loading

Tracking

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Rewritten query planning when using Edge indexing inside Optional. Query plan will prefer to expand from existing nodes rather than use a new edge index to scan over new relationships #2741
  • @katarinasupe

@Josipmrden Josipmrden self-assigned this Feb 25, 2025
@Josipmrden Josipmrden added bug bug community community Docs - changelog only Docs - changelog only CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=jepsen -test=core Run jepsen build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=stress Run release build and stress tests on push CI -build=release -test=benchmark Run release build and benchmark on push CI -build=release -test=query_modules Run release build and query modules tests on push labels Feb 25, 2025
@Josipmrden Josipmrden added this to the mg-v3.1.0 milestone Feb 25, 2025
@Josipmrden Josipmrden marked this pull request as ready for review February 26, 2025 08:58
@Josipmrden Josipmrden linked an issue Feb 26, 2025 that may be closed by this pull request
Edge index causes wrong query results #2737
Closed
Ignition
Ignition reviewed Mar 3, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Josipmrden Josipmrden added this pull request to the merge queue Mar 4, 2025
Merged via the queue into master with commit 2665014 Mar 4, 2025
15 checks passed
@Josipmrden Josipmrden deleted the optional-match-doesnt-use-edge-indices branch March 4, 2025 11:46
@gitbuda gitbuda mentioned this pull request Mar 11, 2025
Merged
49 tasks
as51340 pushed a commit that referenced this pull request Oct 24, 2025
@Josipmrden
Add rewrite for planning inside OPTIONAL (#2741)
e716e51 
Valid plans are rejected if they use edge indices inside optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ignition Ignition Ignition approved these changes

@colinbarry colinbarry Awaiting requested review from colinbarry

Assignees

@Josipmrden Josipmrden

Labels

bug bug CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=jepsen -test=core Run jepsen build and core tests on push CI -build=release -test=benchmark Run release build and benchmark on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=query_modules Run release build and query modules tests on push CI -build=release -test=stress Run release build and stress tests on push community community Docs - changelog only Docs - changelog only

Projects

None yet

Milestone

mg-v3.1.0

Development

Successfully merging this pull request may close these issues.

Edge index causes wrong query results

3 participants

@Josipmrden @Ignition