Skip to content

Add optimization for text.regreplace by caching regex pattern #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Josipmrden merged 3 commits into from
Jul 22, 2025
Merged

Add optimization for text.regreplace by caching regex pattern #641

Josipmrden merged 3 commits into from
Jul 22, 2025

Conversation

@Josipmrden
Copy link
Contributor

@Josipmrden Josipmrden commented Jul 18, 2025 •
edited
Loading

Description

Add optimization for text.regreplace by caching the regex pattern

@Josipmrden Josipmrden added this to the mage-v3.5.0 milestone Jul 18, 2025
@Josipmrden Josipmrden requested review from DavIvek and imilinovic July 18, 2025 12:17
@Josipmrden Josipmrden self-assigned this Jul 18, 2025
@Josipmrden Josipmrden added Docs - changelog only Docs - changelog only apoc bug bug community community customer customer labels Jul 18, 2025
imilinovic
imilinovic requested changes Jul 18, 2025
View reviewed changes
@Josipmrden Josipmrden requested a review from imilinovic July 22, 2025 12:16
@Josipmrden
Copy link
Contributor Author

Josipmrden commented Jul 22, 2025

@imilinovic switched with global cache

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 22, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Josipmrden Josipmrden added this pull request to the merge queue Jul 22, 2025
@Josipmrden
Copy link
Contributor Author

Josipmrden commented Jul 22, 2025

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Add optimization for text.regreplace by caching the regex pattern #641

Merged via the queue into main with commit 67422a2 Jul 22, 2025
9 checks passed
@Josipmrden Josipmrden deleted the text-regreplace-optimization branch July 22, 2025 14:32
@gitbuda gitbuda mentioned this pull request Aug 17, 2025
Merged
81 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imilinovic imilinovic imilinovic approved these changes

@DavIvek DavIvek Awaiting requested review from DavIvek

Assignees

@Josipmrden Josipmrden

Labels

apoc bug bug community community customer customer Docs - changelog only Docs - changelog only

Projects

None yet

Milestone

mage-v3.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Josipmrden @imilinovic