Skip to content

Conversation

@colinbarry
Copy link
Contributor

@colinbarry colinbarry commented Jul 9, 2025

Description

Updates MAGE's date.py to incorporate fixes made to Memgraph's implementation.

This also updates the type of the e2e tests from static to online, as the static tests don't support specifying multiple tests in a single test.yml.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description
  • Write a release note, including added/changed clauses.

Changed date.convert_format to correctly convert iso_zoned_date_time dates. This brings the implementation into line with the equivalent Memgraph query module. #634

@colinbarry colinbarry added Docs unnecessary Docs unnecessary bug bug labels Jul 9, 2025
@colinbarry colinbarry force-pushed the fix/date-version branch 2 times, most recently from 9bc6889 to e245ff2 Compare July 9, 2025 15:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2025

@colinbarry colinbarry self-assigned this Jul 9, 2025
@colinbarry colinbarry marked this pull request as ready for review July 10, 2025 08:03
@colinbarry colinbarry added this pull request to the merge queue Jul 10, 2025
@colinbarry colinbarry added this to the mage-v3.5.0 milestone Jul 10, 2025
Merged via the queue into main with commit 84aae9d Jul 10, 2025
9 checks passed
@colinbarry colinbarry deleted the fix/date-version branch July 10, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug bug Docs unnecessary Docs unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants