Skip to content

Fix max map count #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antejavor merged 4 commits into from
Nov 28, 2024
Merged

Fix max map count #79

antejavor merged 4 commits into from
Nov 28, 2024

Conversation

@antejavor
Copy link
Collaborator

@antejavor antejavor commented Nov 21, 2024 •
edited
Loading

This fix inclued setting up vm.max_map_count to 262144 by default, as specified here

There is an optionality included there.

@antejavor antejavor self-assigned this Nov 22, 2024
@antejavor antejavor marked this pull request as ready for review November 22, 2024 13:09
@antejavor antejavor linked an issue Nov 22, 2024 that may be closed by this pull request
Add config for vm.max_map_count to helm charts. #74
Closed
as51340
as51340 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@as51340 as51340 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to test if this works? Is CI run enough, what do you think? Logs seem ok

@as51340 as51340 self-requested a review November 25, 2024 07:25
as51340
as51340 requested changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add it for HA also

@antejavor antejavor added this to the Memgraph-2.22.0 milestone Nov 25, 2024
@antejavor antejavor requested a review from as51340 November 26, 2024 09:46
@antejavor antejavor mentioned this pull request Nov 28, 2024
Merged
@antejavor antejavor merged commit 4f174b9 into main Nov 28, 2024
3 checks passed
@antejavor antejavor deleted the fix-vm-max-map-count branch November 28, 2024 08:40
as51340 pushed a commit that referenced this pull request Dec 2, 2024
@antejavor
Fix max map count (#79)
57a5934 
Add a fix for max map count.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@as51340 as51340 as51340 approved these changes

@katarinasupe katarinasupe Awaiting requested review from katarinasupe katarinasupe is a code owner

Assignees

@antejavor antejavor

Labels

None yet

Projects

None yet

Milestone

Memgraph-2.22.0

Development

Successfully merging this pull request may close these issues.

Add config for vm.max_map_count to helm charts.

3 participants

@antejavor @as51340