Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Indexclass is immutable, requiring an immutable type for a property. This means that a tuple must be used instead of a list. Hence, the list returned from Memgraph will be converted to a tuple post initialization so it can be properly handled. From the user perspective, they can define property in the label-property index with a tuple or a list - both should work as expected. If the label property index is not composite, a simple string for the property should work as expected as well. These changes are handled in theIndexandMemgraphIndexclasses inmodels.py._convert_index_typeprocedure inmemgraph.py), based on different Cypher queries used for their creation and deletion -LABEL(default, used for label andlabel+propertyindex types, including composite indexes),EDGE(used foredge-typeandedge-type+property),EDGE_GLOBAL(used foredge-property) andPOINT(used forpointindex). By doing that,get_indexes,ensure_indexes,drop_indexesfrom thememgraph.pyanddrop_indexandcreate_indexprocedures from thedatabase_client.pyshould be working as expected (anddrop_indexandcreate_indexbecame abstract, as the changes are Memgraph-related). Theto_cypherprocedure from theIndexclass was affected by this change as well. Since this change is Memgraph-related,to_cypherbecame abstract.SHOW INDEX INFOquery).Pull request type
Please delete options that are not relevant.
Related issues
Closes #348
Checklist:
######################################
Reviewer checklist (the reviewer checks this part)
######################################