core: build_id: support alternate GNU build ID sources #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External build systems may already be enabling GNU build ID, in which case the Memfault provided implementation either breaks the upstream version or doesn't work. By enabling `MEMFAULT_GNU_BUILD_ID_CUSTOM` the query for the build ID is offloaded to the application. Signed-off-by: Jordan Yates <jordan.yates@data61.csiro.au>
|
Closed in favour of #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External build systems may already be enabling GNU build ID, in which case the Memfault provided implementation either breaks the upstream version or doesn't work.
By enabling
MEMFAULT_GNU_BUILD_ID_CUSTOMthe query for the build ID is offloaded to the application.This enables integration with solutions such as zephyrproject-rtos/zephyr#51532, and presumably the final result of zephyrproject-rtos/zephyr#54464