rename z_NmiHandlerSet to z_arm_nmi_set_handler #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
carlescufi
reviewed
Apr 21, 2023
| @@ -28,8 +28,8 @@ | |||
| // Since we don't use the arguments we match anything with () to avoid | |||
| // compiler warnings and share the same bootup logic | |||
| static int prv_install_nmi_handler() { | |||
| extern void z_NmiHandlerSet(void (*pHandler)(void)); | |||
| z_NmiHandlerSet(MEMFAULT_EXC_HANDLER_NMI); | |||
| extern void z_arm_nmi_set_handler(void (*pHandler)(void)); | |||
There was a problem hiding this comment.
Is this the right file?
ports/zephyr/v2.4/memfault_fault_handler.c
This is for Zephyr v2.4, and back then the function was still named z_NmiHandlerSet()?
There was a problem hiding this comment.
Changing it there fixes the build issue. Maybe there needs to be another version.
There was a problem hiding this comment.
Right. But this might then break the build against older Zephyr versions?
|
Thanks @carlescufi + @maxd-nordic , this should be solved in (cc #49 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #49