Allow the memfault coredump --region command to take GDB variables as arguments
#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the arguments for --regions must be integers. Passing `memfault coredump --region (uint32_t)&_ram_start (uint32_t)&_ram_size` or `memfault coredump --region $coredump_start $coredump_size` will result in errors. This change will evaluate the arguments if they are not integers
|
We've merged the fix into our main branch and it will be available on the next package & release cycle. Thanks for filing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the arguments for --region must be integers.
Passing
memfault coredump --region (uint32_t)&_ram_start (uint32_t)&_ram_sizeormemfault coredump --region $coredump_start $coredump_sizewill result in errors.This change will evaluate the arguments if they are not integers :D