[REVIEW] 398 - Fix unavailable local smtp envs #405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accordingly to #398, local smtp local variables is not being defined by
docker-compose.yml
. So, it solves this problem and, furthermore, include all SMTP variables to envs (server, port, email, password).How to test: to test this pull request, you will need to use a SMTP server. You can use a gmail account (I recommend to create a test account), change the Less secure app access and fill the
.smtp
file.Resolves (Issues)
Resolve #398
General tasks performed
SMTP_SERVER
andSMTP_PORT
to environment variables;docker-compose.yml
with smtp env file;.dev_deploy
,.prod_deploy
and.staging_deploy
with all SMTP variables.Have you confirmed the application builds locally without error? See here.