Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] 398 - Fix unavailable local smtp envs #405

Conversation

WelisonR
Copy link
Contributor

@WelisonR WelisonR commented Apr 7, 2021

Description

Accordingly to #398, local smtp local variables is not being defined by docker-compose.yml. So, it solves this problem and, furthermore, include all SMTP variables to envs (server, port, email, password).

How to test: to test this pull request, you will need to use a SMTP server. You can use a gmail account (I recommend to create a test account), change the Less secure app access and fill the .smtp file.

Resolves (Issues)

Resolve #398

General tasks performed

  • Add SMTP_SERVER and SMTP_PORT to environment variables;
  • Update docker-compose.yml with smtp env file;
  • Update .dev_deploy, .prod_deploy and .staging_deploy with all SMTP variables.

Have you confirmed the application builds locally without error? See here.

  • Yes

@WelisonR WelisonR added the bug Something isn't working label Apr 7, 2021
@WelisonR WelisonR self-assigned this Apr 7, 2021
@WelisonR WelisonR changed the title [REVIEW] 398 Fix unavailable local smtp envs [REVIEW] 398 - Fix unavailable local smtp envs Apr 22, 2021
@pablodiegoss pablodiegoss merged commit 4dca8c1 into memeLab:develop Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMTP credentials not avaliable in local enviroment
3 participants