Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Refactoring of recover password implementation #366

Merged
merged 5 commits into from
Feb 14, 2021
Merged

[REVIEW] Refactoring of recover password implementation #366

merged 5 commits into from
Feb 14, 2021

Conversation

devsalula
Copy link
Contributor

@devsalula devsalula commented Nov 30, 2020 •
edited
Loading

Description

This Pull Request is focused on improving the implementation of the recover password method, adapting it to clean code and solid.

Resolves (Issues)

#365

General tasks performed

  • Reduce the number of lines of the recover password method
  • Make sure everything works with unit tests
  • Organize methods in classes

Have you confirmed the application builds locally without error? See here.

  • Yes
  • No

@pablodiegoss pablodiegoss merged commit c736394 into memeLab:develop Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablodiegoss pablodiegoss pablodiegoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devsalula @pablodiegoss