Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an user, I want to see the name of a content, so I can identify it. #161

Closed
rodrigocam opened this issue Apr 30, 2019 · 14 comments
Closed
Assignees
Labels
bug Something isn't working CMS enhancement New feature or request user
Milestone

Comments

@rodrigocam
Copy link
Member

rodrigocam commented Apr 30, 2019

Make a modal page to visualize a list of markers or artworks being able to select them

@rodrigocam rodrigocam self-assigned this May 31, 2019
@vjpixel
Copy link
Member

vjpixel commented Jun 24, 2019

Can you please link the page?

@rodrigocam
Copy link
Member Author

We don't have specific pages for modal, to test you have to click on a marker, object or artwork.
https://dev.jandig.app/collection/ here you can test all this possibilities.

@vjpixel
Copy link
Member

vjpixel commented Jun 24, 2019 via email

@vjpixel vjpixel changed the title Item (marker, etc) visualization modal 7. Item (marker, etc) visualization modal Jun 25, 2019
@vjpixel
Copy link
Member

vjpixel commented Jul 10, 2019

The title of the item isn't been showing.

Screenshot from 2019-07-10 14-05-46

@pablodiegoss
Copy link
Member

The title isn't from a marker or object, just an artwork

@vjpixel
Copy link
Member

vjpixel commented Jul 18, 2019

We have markers and objects with different names from the artworks.

Also, the modal for artworks aren't showing the name too.

@vjpixel
Copy link
Member

vjpixel commented Sep 21, 2019

Do you need any more information @rodrigocam ?

@vjpixel vjpixel added this to the Launch milestone Sep 21, 2019
@rodrigocam
Copy link
Member Author

No need, ty

@vjpixel
Copy link
Member

vjpixel commented Oct 8, 2019

Part of solving this issue is creating a "Title" field for the markers/objects.

@vjpixel vjpixel added the bug Something isn't working label Oct 30, 2019
@vjpixel vjpixel changed the title 7. Item (marker, etc) visualization modal As an user, I want to see the name of a content, so I can identify it. Jan 31, 2020
@vjpixel vjpixel added the enhancement New feature or request label Jan 31, 2020
@hockpond hockpond assigned hockpond and unassigned rodrigocam Feb 12, 2020
@hockpond
Copy link
Contributor

What need to be done: Create a name field to markers and objects and show these names when clicking on these elemens.
How it will be executed: Marker and object names will be included in its models on the database. Old markers and objects will have an empty name, meaning that clicking on them will return the same currently result. However, it will be possible to choose a name by clicking on an edditing button. Moreover, new markers and objects will only be created with names and all the markers and objects with names when be clicked will be shown with the properly names.

@hockpond
Copy link
Contributor

The edit tool which I talked in last comment will be let to be implemented at issue #307.

@vjpixel
Copy link
Member

vjpixel commented Feb 13, 2020

OK

@hockpond
Copy link
Contributor

please, review @vjpixel

@vjpixel
Copy link
Member

vjpixel commented Feb 14, 2020

Done! Great job!

@vjpixel vjpixel closed this as completed Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMS enhancement New feature or request user
Projects
None yet
Development

No branches or pull requests

4 participants