Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links for artworks/objects/markers #251

Closed
vjpixel opened this issue Oct 8, 2019 · 8 comments
Closed

links for artworks/objects/markers #251

vjpixel opened this issue Oct 8, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@vjpixel
Copy link
Member

vjpixel commented Oct 8, 2019

If a user is on an artwork modal or exhibition page, s/he can't click on a content (marker/object/artwork). If the user wants to see the content, it needs to go back to the Collection page and find it.

The contents should have links so the user can simply click and go to it's page.

@vjpixel vjpixel added the enhancement New feature or request label Oct 8, 2019
@vjpixel vjpixel changed the title links for artworks/objects/markers in all windows links for artworks/objects/markers Oct 8, 2019
@vjpixel vjpixel closed this as completed Nov 20, 2019
@vjpixel vjpixel removed the duplicate label Nov 20, 2019
@vjpixel vjpixel reopened this Nov 20, 2019
@anacforcelli anacforcelli self-assigned this Dec 26, 2019
@anacforcelli
Copy link
Contributor

I'm making changes to item-list.jinja2 to generate modals for both the markers and the objects.

@anacforcelli
Copy link
Contributor

According to issue #248 , the object modal should support video formats.

@vjpixel
Copy link
Member Author

vjpixel commented Jan 13, 2020

There are already modals for markers and objects, what is missing are links between contents.

Examples:

If I open the Exhibition Longa Vida à Jandig! on the CMS (https://jandig.app/exhibit/?id=1) I see a list of Artworks. I should be able to click on those artworks and open them.

If I open an Artwork I should be able to click on the Marker or the Object and open them.

@anacforcelli
Copy link
Contributor

Captura de tela de 2020-01-13 21-34-38

Me and Pablo fixed this. There was a missing include in the exhibit-details.jinja2 file.

@anacforcelli
Copy link
Contributor

@vjpixel please review this pull request

@vjpixel
Copy link
Member Author

vjpixel commented Jan 14, 2020

Very good!

The links to the artworks are there, but there aren't links for the markers/objects from the artworks modal (like I described above).

@anacforcelli
Copy link
Contributor

@vjpixel now it is fixed, please review.

@vjpixel
Copy link
Member Author

vjpixel commented Jan 20, 2020

great!

@vjpixel vjpixel closed this as completed Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants