-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
links for artworks/objects/markers #251
Comments
I'm making changes to item-list.jinja2 to generate modals for both the markers and the objects. |
According to issue #248 , the object modal should support video formats. |
There are already modals for markers and objects, what is missing are links between contents. Examples: If I open the Exhibition Longa Vida à Jandig! on the CMS (https://jandig.app/exhibit/?id=1) I see a list of Artworks. I should be able to click on those artworks and open them. If I open an Artwork I should be able to click on the Marker or the Object and open them. |
@vjpixel please review this pull request |
Very good! The links to the artworks are there, but there aren't links for the markers/objects from the artworks modal (like I described above). |
@vjpixel now it is fixed, please review. |
great! |
If a user is on an artwork modal or exhibition page, s/he can't click on a content (marker/object/artwork). If the user wants to see the content, it needs to go back to the Collection page and find it.
The contents should have links so the user can simply click and go to it's page.
The text was updated successfully, but these errors were encountered: