Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glossary formatting and ordering adjustments #86

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Glossary formatting and ordering adjustments #86

merged 3 commits into from
Nov 16, 2023

Conversation

kidq330
Copy link
Collaborator

@kidq330 kidq330 commented Nov 14, 2023

No description provided.

@kidq330 kidq330 requested a review from varsill November 14, 2023 09:50
varsill
varsill requested changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@varsill varsill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👏
I have spotted a little oversight, you can find it in a comment below

@kidq330 kidq330 requested a review from varsill November 15, 2023 12:36
varsill
varsill approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@varsill varsill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@kidq330 kidq330 merged commit 1523d0e into main Nov 16, 2023
@kidq330 kidq330 deleted the glossary_suggestions branch November 16, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varsill varsill varsill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kidq330 @varsill