Use membrane objects in builders#193
Merged
carnage merged 34 commits intomembrane-php:mainfrom Jan 10, 2025
Merged
Conversation
Some Schemas create subschemas. Membrane objects can only be relied on fully once: - Schema objects are constructed from Membrane objects
This had been commented out previously. Uncommented and tweaked to pass
Tests fail currently
"not" is always a Schema and defaults to the false Schema. The check needs to update to reflect that.
Required is always an array. The check needs to ensure "required" is not empty instead.
No change to behaviour.
Type-specific schemas no longer handle nullable. It all takes place in the APIBuilder.
Previously if allOf, anyOf or oneOf were found, the rest of the top level schema would be ignored. This commit changes that so that the whole schema is considered.
charjr
force-pushed
the
use-membrane-objects-in-builders
branch
from
160ebcf to
48f9268
Compare
carnage
approved these changes
Jan 10, 2025
This was referenced Jan 10, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.