Complex schema message branches#162
Merged
carnage merged 2 commits intomembrane-php:mainfrom Jan 9, 2024
Merged
Conversation
charjr
changed the title
charjr
changed the title
charjr
force-pushed
the
complex-schema-message-branches
branch
from
a1e72ed to
e1113a5
Compare
charjr
force-pushed
the
complex-schema-message-branches
branch
from
e1113a5 to
e93c220
Compare
charjr
changed the title
carnage
approved these changes
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #135
subschemas within AnyOf|AllOf|OneOf will have the sub-schema's title if available or fallback to 'Branch 1', 'Branch 2' etc.
Refactors all complex schemas to use same method.
Adds a conditional check for empty complex schemas which are technically valid but completely pointless.