[FIXED #104240680] Objectlink's clickable redirect does not prevent click propagation on Safari#87
Open
tomatell wants to merge 1 commit intomembery:masterfrom
Open
[FIXED #104240680] Objectlink's clickable redirect does not prevent click propagation on Safari#87tomatell wants to merge 1 commit intomembery:masterfrom
tomatell wants to merge 1 commit intomembery:masterfrom
Conversation
…lick propagation on Safari - removed a focus trigger handler form enterEditMode to evade looping of the event - added a div wrapper around the link arrow icon so that the inline edit can recognize the source element of the focus event; i.e. if the link arrow is focused it will not call enterEditMode method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lick propagation on Safari
element of the focus event; i.e. if the link arrow is focused it will not call enterEditMode method.