-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat: add thinking mode support to fact retrieval messages #3626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vedant817
wants to merge
3
commits into
mem0ai:main
Choose a base branch
from
Vedant817:feature/thinking-mode-memory-utils
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−12
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| from mem0.configs.settings import settings | ||
|
|
||
| __all__ = ["settings"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| from typing import Any, Dict | ||
| from mem0.configs.base import MemoryConfig | ||
|
|
||
| class Settings: | ||
| """Settings class to manage configuration.""" | ||
|
|
||
| def __init__(self): | ||
| """Initialize settings with default configuration.""" | ||
| self.config = {} | ||
| self._memory_config = MemoryConfig() | ||
|
|
||
| def configure(self, config: Dict[str, Any]) -> None: | ||
| """ | ||
| Configure settings with provided configuration. | ||
|
|
||
| Args: | ||
| config: Dictionary containing configuration settings | ||
| """ | ||
| self.config.update(config) | ||
|
|
||
| @property | ||
| def memory_config(self) -> MemoryConfig: | ||
| """Get the memory configuration.""" | ||
| return self._memory_config | ||
|
|
||
| @memory_config.setter | ||
| def memory_config(self, config: MemoryConfig) -> None: | ||
| """ | ||
| Set the memory configuration. | ||
|
|
||
| Args: | ||
| config: MemoryConfig instance | ||
| """ | ||
| self._memory_config = config | ||
|
|
||
|
|
||
| # Create a singleton instance | ||
| settings = Settings() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not how we are planning to introduce the config, there are set of parameters for every provider - ollama, lmstudio where thinking mode toggle can be configured, this is a prompt based mechanism and not a config base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vedant817 please look at the comments here, this seems to be unresolved.