This repository has been archived by the owner on Jun 8, 2024. It is now read-only.
feat: add typescript support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing! I was just hunting for a @types/embedchain. Hopefully @taranjeet is OK with TS. It'd be quite helpful to have TS support. |
yeah I think it's going to greatly improve the dev experience and allow us to iterate quicker. |
|
looks good @cachho |
|
Would it be possible to push a new release to npm including this PR? I can always build locally in the meantime, but deploying to "prod" (not really production, just a hosted playground) would be easier. Thanks! |
|
hey @justingrant , npm release is planned for today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewrote the whole package in typescript.
sucessfully tested against the javascript example in a javascript file.