This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Support publisher confirmations #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Context:** [Publisher confirmations](https://www.rabbitmq.com/confirms.html#publisher-confirms), is a mechanism to ensure that a published message actually reached a broker. **How:** Extend, publisher configuration with two optional attributes: * `activate_confirmations` - when set to `true`, confirmations will be activated on the channel during publisher setup + confirmation will be awaited on every publish * `max_confirmation_wait_time` - maximum time in seconds, that publisher will wait for a confirmation from a broker before timeouting **Other:** * Move test publishers to a separate module
mkorszun
commented
Sep 20, 2019
vorce
reviewed
Sep 20, 2019
test/support/test_publishers.ex
Outdated
| exchange: "gen_rmq_out_exchange", | ||
| uri: "amqp://guest:guest@localhost:5672", | ||
| app_id: :my_app_id, | ||
| activate_confirmations: true |
There was a problem hiding this comment.
Should be enable_confirmations: true
There was a problem hiding this comment.
Good catch! It makes me to realize that it is hard to test confirmations :/ Any ideas?
There was a problem hiding this comment.
Hmm yeah. Only thing I can think of is to use a mock AMQP.Confirm.wait_for_confirms somehow. :\
vorce
approved these changes
Sep 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publisher confirmations, is a mechanism to ensure that a published message actually reached a broker.
How:
Extend publisher configuration with two optional attributes:
enable_confirmations- when set totrue, confirmations will be activated on the channel during publisher setup + confirmation will be awaited on every publishmax_confirmation_wait_time- maximum time in milliseconds, that publisher will wait for a confirmation from a broker before timeoutingOther:
Description
Checklist