Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create simple custom webview for Android to open /posts links #41

Open
pranavsb opened this issue Oct 4, 2020 · 0 comments
Open

Create simple custom webview for Android to open /posts links #41

pranavsb opened this issue Oct 4, 2020 · 0 comments
Labels
android-only Affects only Android users enhancement New feature or request

Comments

@pranavsb
Copy link
Member

pranavsb commented Oct 4, 2020 •
edited
Loading

Links specified in the markdown of "posts" articles should ideally open an in-app webview.
While this works very nicely on iOS with forceSafariVC set to true, on Android the default webview is not really nice.
We tried to improve it by enabling JS and allowing HTTP links in #34, but there's no progress indicator for the page load and no way to copy link (to open in browser).

So until we implement a simple Webview for Android (reusable even in iOS, if decent enough), let's just force Android Markdown links to open in the default browser.
@pranavsb pranavsb added enhancement New feature or request android-only Affects only Android users labels Oct 4, 2020
pranavsb added a commit that referenced this issue Oct 4, 2020
@pranavsb
feat(posts): Open Markdown links in Android browser
406c19c 
iOS will continue to be opened in Safari VC. See #41 for details
@pranavsb pranavsb mentioned this issue Oct 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android-only Affects only Android users enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pranavsb