Skip to content

feat: Add a new built-in target test for stream name parts (<db>-<schema>-<name>, <schema>-<name>) - #3777

Draft
edgarrmondragon wants to merge 1 commit into
mainfrom
feat/test-stream-name-parts
Draft

edgarrmondragon wants to merge 1 commit into
mainfrom
feat/test-stream-name-parts

Conversation

@edgarrmondragon

@edgarrmondragon edgarrmondragon commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator

Related

Summary by Sourcery

New Features:

  • Add a built-in target test covering stream names composed from database, schema, and table name parts.

…hema>-<name>`, `<schema>-<name>`)

Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
@edgarrmondragon edgarrmondragon added this to the v0.55 milestone Sep 11, 2026
@edgarrmondragon edgarrmondragon added testing SQL Support for SQL taps and targets Type/Target Singer targets labels Sep 11, 2026
@edgarrmondragon edgarrmondragon self-assigned this Sep 11, 2026
@sourcery-ai

sourcery-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduces and enables a built-in target test that verifies targets correctly handle stream names composed from database, schema, and stream name parts, including the schema-name form.

File-Level Changes

Change Details Files
Adds a reusable built-in target test fixture for validating stream-name component handling.
  • Adds a fixture stream containing names for database/schema/name and schema/name forms.
  • Defines a target test template that loads the new fixture.
  • Registers the test in the built-in Singer test suite.
singer_sdk/testing/target_test_streams/stream_name_parts.singer
singer_sdk/testing/target_tests.py
singer_sdk/testing/suites.py

Possibly linked issues

  • #bug-hyphenated-stream-name: The new stream-name-parts target test directly covers the issue’s incorrect handling of hyphenated stream names.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.47%. Comparing base (43b3563) to head (c2733af).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3777   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files          74       74           
  Lines        6298     6300    +2     
  Branches      771      771           
=======================================
+ Hits         5950     5952    +2     
  Misses        260      260           
  Partials       88       88           
Flag Coverage Δ
core 83.09% <100.00%> (+<0.01%) ⬆️
end-to-end 76.22% <100.00%> (+<0.01%) ⬆️
optional-components 45.00% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Sep 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 14 untouched benchmarks


Comparing feat/test-stream-name-parts (c2733af) with main (43b3563)

Open in CodSpeed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SQL Support for SQL taps and targets testing Type/Target Singer targets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant