Repository navigation
fix: Bump standard tap tests max records limit from 25 to 150 - #3030
Merged
Merged
Conversation
Contributor
Reviewer's GuideAdjusts the default limit for standard tap tests by increasing the maximum records threshold in the testing configuration to support larger datasets. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @edgarrmondragon - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3030 +/- ##
==========================================
+ Coverage 91.66% 91.68% +0.01%
==========================================
Files 62 62
Lines 5314 5314
Branches 684 684
==========================================
+ Hits 4871 4872 +1
Misses 311 311
+ Partials 132 131 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #3030 will not alter performanceComparing Summary
|
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 11, 2026
…ests (#3556) https://github.com/meltano/sdk/blob/4a5dd894d69cc068d140acea6e15fa4040831611/singer_sdk/tap_base.py#L284-L286 ## Related - #3029 - #3030 - #3037 - #3545 ## Summary by Sourcery Adjust tap dry-run behavior to cap record counts on all streams while ensuring parent streams continue emitting records when child streams hit their record limits. Bug Fixes: - Prevent auto-generated dry-run syncs from aborting parent streams when child streams reach their record limit by catching child abort exceptions and stopping only remaining child syncs. - Apply the dry-run record limit consistently to both parent and child streams so all streams are subject to the same cap. ## Summary by Sourcery Ensure dry-run syncs apply record limits consistently across parent and child streams without preventing parent records from being emitted when children hit their cap. Bug Fixes: - Apply the dry-run record limit to all streams, including parents and children, instead of only non-child streams. - Prevent child stream aborts due to dry-run record limits from stopping sibling or parent stream processing by catching abort exceptions during child sync. Tests: - Add a regression test verifying that parent and sibling records are still emitted, and child records are correctly capped, when a child stream hits the dry-run record limit. --------- Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
No records returned in streamtest failures with newmax_records_limitdefault #3029Summary by Sourcery
Bug Fixes: