-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Developers can now more easily override the mapping from SQL column type to JSON schema #2618
feat: Developers can now more easily override the mapping from SQL column type to JSON schema #2618
Conversation
CodSpeed Performance ReportMerging #2618 will not alter performanceComparing Summary
|
d31b97c
to
a2f842a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2618 +/- ##
==========================================
+ Coverage 89.61% 89.82% +0.21%
==========================================
Files 58 58
Lines 4861 4884 +23
Branches 955 959 +4
==========================================
+ Hits 4356 4387 +31
+ Misses 352 346 -6
+ Partials 153 151 -2 ☔ View full report in Codecov by Sentry. |
39fe949
to
f91aff4
Compare
…ON schema mapping
f91aff4
to
af47b26
Compare
601f4c8
to
ca2eab0
Compare
Hey @edgarrmondragon 👋 This is great! Are there plans to replace |
Hey @kgpayne, it's nice to see you around these parts!
That's the plan. I'll give it a try and see what I come up with tomorrow. |
I've made a reference implementation in MeltanoLabs/target-postgres#469 if anyone's interested in looking. |
Related:
date
types causes schema validation to fail intarget-postgres
#1831maxLength
to schema MeltanoLabs/tap-postgres#485New docs links:
📚 Documentation preview 📚: https://meltano-sdk--2618.org.readthedocs.build/en/2618/