Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use a single source of truth for built-in capabilities #2505

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jun 25, 2024

  • Documentation (display the config property descriptors nicely)
  • Code coverage

📚 Documentation preview 📚: https://meltano-sdk--2505.org.readthedocs.build/en/2505/

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/capabilities branch 5 times, most recently from b743009 to 334eca3 Compare June 25, 2024 17:10
Copy link

codspeed-hq bot commented Jun 25, 2024

CodSpeed Performance Report

Merging #2505 will not alter performance

Comparing edgarrmondragon/refactor/capabilities (c2ca5e2) with main (39e1619)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (39e1619) to head (c2ca5e2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2505      +/-   ##
==========================================
+ Coverage   89.50%   89.63%   +0.12%     
==========================================
  Files          58       60       +2     
  Lines        4804     4803       -1     
  Branches      943      936       -7     
==========================================
+ Hits         4300     4305       +5     
+ Misses        351      347       -4     
+ Partials      153      151       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/capabilities branch 6 times, most recently from 4be7e31 to 93bbe08 Compare July 1, 2024 14:05
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/capabilities branch from 93bbe08 to 5b4a7e6 Compare July 16, 2024 18:19
@edgarrmondragon edgarrmondragon added this to the 0.41.0 milestone Aug 14, 2024
@edgarrmondragon edgarrmondragon modified the milestones: v0.41.0, v0.42.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant