-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Nested schema properties can now be defined as nullable #2488
Merged
edgarrmondragon
merged 7 commits into
main
from
edgarrmondragon/feat/nested-nullable-props
Oct 18, 2024
Merged
feat: Nested schema properties can now be defined as nullable #2488
edgarrmondragon
merged 7 commits into
main
from
edgarrmondragon/feat/nested-nullable-props
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
edgarrmondragon
changed the title
feat: Let nested properties be nullable
feat: Nested schema properties can now be defined as nullable
Jun 18, 2024
CodSpeed Performance ReportMerging #2488 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2488 +/- ##
=======================================
Coverage 90.70% 90.70%
=======================================
Files 62 62
Lines 5015 5016 +1
Branches 641 641
=======================================
+ Hits 4549 4550 +1
Misses 325 325
Partials 141 141 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/nested-nullable-props
branch
from
July 16, 2024 18:19
4b40976
to
8b05077
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/nested-nullable-props
branch
from
August 9, 2024 21:31
8b05077
to
4df8e21
Compare
edgarrmondragon
deleted the
edgarrmondragon/feat/nested-nullable-props
branch
October 18, 2024 03:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2487
📚 Documentation preview 📚: https://meltano-sdk--2488.org.readthedocs.build/en/2488/