Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generic incremental replication support for BATCH mode in SQL taps #1894

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 3, 2023

@edgarrmondragon edgarrmondragon changed the title Process inspected schemas only once during discovery feat: Generic incremental replication support for BATCH mode Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1894 (ea44786) into main (f1f87ac) will decrease coverage by 0.05%.
The diff coverage is 84.70%.

@@            Coverage Diff             @@
##             main    #1894      +/-   ##
==========================================
- Coverage   86.83%   86.78%   -0.05%     
==========================================
  Files          58       58              
  Lines        4885     4965      +80     
  Branches      777      795      +18     
==========================================
+ Hits         4242     4309      +67     
- Misses        456      462       +6     
- Partials      187      194       +7     
Files Coverage Δ
singer_sdk/exceptions.py 100.00% <100.00%> (ø)
singer_sdk/helpers/_batch.py 91.80% <100.00%> (+1.14%) ⬆️
singer_sdk/helpers/capabilities.py 92.42% <ø> (ø)
singer_sdk/target_base.py 92.27% <100.00%> (ø)
singer_sdk/connectors/sql.py 83.97% <50.00%> (-0.45%) ⬇️
singer_sdk/streams/core.py 83.99% <50.00%> (-0.32%) ⬇️
singer_sdk/helpers/_typing.py 73.39% <50.00%> (-0.67%) ⬇️
singer_sdk/batch.py 92.10% <86.66%> (-7.90%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as draft August 3, 2023 21:12
@edgarrmondragon edgarrmondragon force-pushed the 976-initialize-batch-replication-values branch from dc9c873 to 8bc01f5 Compare August 10, 2023 18:31
@edgarrmondragon edgarrmondragon changed the title feat: Generic incremental replication support for BATCH mode feat: Generic incremental replication support for BATCH mode in SQL targets Aug 10, 2023
@edgarrmondragon edgarrmondragon changed the title feat: Generic incremental replication support for BATCH mode in SQL targets feat: Generic incremental replication support for BATCH mode in SQL taps Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant