You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I get ValueError: Out of range float values are not JSON compliant when trying to sync Amazon Document DB collection.
The probably reason is that simple_json.dumps() has allow_nan=False default, while standard dumps() function from standard json library has allow_nan=True.
As there is no way to pass configuration from outside could we add this functionality? I can introduce relevant fix.
Code
No response
The text was updated successfully, but these errors were encountered:
I think having allow_nan by default would violate the interoperability principle in the Singer ecosystem since it's specific to Python's JSON implementation: while most taps and targets are written in Python, they could be programmed in any language.
There's also the question of how the jsonchema library that we use for validation on the target side would treat the NaN values, although it's now possible to disable validation on the user end (631d5df), if they're fine with moving NaNs around and skipping schema validation.
Do start a PR and we can discuss the details there!
Singer SDK Version
0.34.1
Is this a regression?
Python Version
3.9
Bug scope
Taps (catalog, state, etc.)
Operating System
MacOS
Description
I get
ValueError: Out of range float values are not JSON compliant
when trying to sync Amazon Document DB collection.The probably reason is that
simple_json.dumps()
hasallow_nan=False
default, while standarddumps()
function from standardjson
library hasallow_nan=True
.As there is no way to pass configuration from outside could we add this functionality? I can introduce relevant fix.
Code
No response
The text was updated successfully, but these errors were encountered: