Skip to content

feat: Handling of "inf" and similar NaN values #2211

Open

Description

Feature scope

Taps (catalog, state, stream maps, tests, etc.)

Description

For example, the Postgres NUMERIC type supports the following:

In addition to ordinary numeric values, the numeric type has several special values:


Infinity
-Infinity
NaN

Python clients usually represent those as math.inf, -math.inf and math.nan respectively. However, for interoperability reasons these NaN values are not supported in JSON or JSON Schema.

Currently, they cause the tap to crash if present, during serialization. This library uses simplejson, so the ignore_nan parameter is available to make the values null but it's unclear whether this silent data loss behavior is preferable to crashing.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions