Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add sql-datatype to the SDK discovery and catalog. #1323

Open
BuzzCutNorman opened this issue Jan 13, 2023 · 2 comments · May be fixed by #1872
Open

[Feature]: Add sql-datatype to the SDK discovery and catalog. #1323

BuzzCutNorman opened this issue Jan 13, 2023 · 2 comments · May be fixed by #1872
Labels
Accepting Pull Requests kind/Feature New feature or request SQL Support for SQL taps and targets valuestream/SDK

Comments

@BuzzCutNorman
Copy link
Contributor

Feature scope

Taps (catalog, state, stream maps, etc.)

Description

It would be very helpful if SDK based taps during the discovery process of a database grabbed column data types and placed them into the catalog metadata area for the column in the field of sql-datatype. The sql-datatype field is a reserved keyword mentioned in the singer discovery documentation.

https://github.com/singer-io/getting-started/blob/master/docs/DISCOVERY_MODE.md#metadata

Keyword Tap Type Discoverable? Description
sql-datatype database discoverable Represents the datatype of the database column
        {
          "breadcrumb": [
            "properties",
            "name"
          ],
          "metadata": {
            "sql-datatype": "varchar(255)",
            "selected-by-default": true
          }
        }
@BuzzCutNorman BuzzCutNorman changed the title [Feature]: Added sql-datatype to the SDK discovery and catalog [Feature]: Add sql-datatype to the SDK discovery and catalog. Jan 13, 2023
@stale
Copy link

stale bot commented Jul 18, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@edgarrmondragon
Copy link
Collaborator

Related: #1903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting Pull Requests kind/Feature New feature or request SQL Support for SQL taps and targets valuestream/SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants