Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to pytest-docker v1 #6547

Merged
merged 5 commits into from
Aug 2, 2022
Merged

chore: Upgrade to pytest-docker v1 #6547

merged 5 commits into from
Aug 2, 2022

Conversation

WillDaSilva
Copy link
Member

Closes #6496

@WillDaSilva WillDaSilva requested a review from a team as a code owner August 2, 2022 13:54
@WillDaSilva WillDaSilva self-assigned this Aug 2, 2022
@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for meltano ready!

Name Link
🔨 Latest commit d25a65e
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/62e96b82c2cc20000866a872
😎 Deploy Preview https://deploy-preview-6547--meltano.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@WillDaSilva
Copy link
Member Author

I updated the Poetry lock file using Poetry 1.1.13, which had a bug that would set all updated entries under [metadata.files] to []. My hope is that updating the lock file with Poetry 1.1.14, then running the tests again should fix the issue in CI.

The version I used previously, `1.1.13`, had a bug that would set all updated entries under `[metadata.files]` to `[]`
@edgarrmondragon
Copy link
Collaborator

I updated the Poetry lock file using Poetry 1.1.13, which had a bug that would set all updated entries under [metadata.files] to []. My hope is that updating the lock file with Poetry 1.1.14, then running the tests again should fix the issue in CI.

@WillDaSilva this might help python-poetry/poetry#5988 (comment)

@WillDaSilva
Copy link
Member Author

this might help python-poetry/poetry#5988 (comment)

@edgarrmondragon Thanks for the link. I had already cleared my Poetry cache before generating the lock file for 6ade6a7, yet unfortunately the problem remains.

I've been able to reproduce locally. The same failures occur on main after updating the lock file, so it seems like we will have to put a max version restriction on one of the non-dev dependencies that poetry update touched. These include:

  • alembic
  • astroid
  • atomicwrites
  • blinker
  • cryptography
  • distlib
  • flask
  • flask-login
  • identify
  • importlib-resources
  • markdown
  • python-gitlab
  • urllib3
  • yarl
  • zipp

Or we can just get to the bottom of this, and fix whatever bug is causing this if it within our own code.

@WillDaSilva
Copy link
Member Author

Keeping flask-login at 0.6.1 fixes the failing tests.

When the tests are run in isolation, they do not error, regardless of whether I had flask-login at 0.6.1 or 0.6.2, which suggests that resolving #6300 would address the underlying issue here.

Relevant changelog: https://github.com/maxcountryman/flask-login/blob/main/CHANGES.md#version-062

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #6547 (d25a65e) into main (c9c1737) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6547   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files          95       95           
  Lines        8349     8349           
  Branches      398      398           
=======================================
  Hits         8059     8059           
  Misses        227      227           
  Partials       63       63           

Help us with your feedback. Take ten seconds to tell us how you rate us.

pyproject.toml Outdated Show resolved Hide resolved
@edgarrmondragon
Copy link
Collaborator

@WillDaSilva can you enable the Windows x Python 3.10 tests on this PR to see if this fixes them?

Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
@WillDaSilva
Copy link
Member Author

@WillDaSilva can you enable the Windows x Python 3.10 tests on this PR to see if this fixes them?

I was planning to do that after this PR goes through, to avoid introducing errors to this one if something goes wrong.

@edgarrmondragon
Copy link
Collaborator

I was planning to do that after this PR goes through, to avoid introducing errors to this one if something goes wrong.

@WillDaSilva sounds good 👍

@WillDaSilva WillDaSilva merged commit 8da44c1 into main Aug 2, 2022
@WillDaSilva WillDaSilva deleted the pytest-docker-v1 branch August 2, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to pytest-docker v1
2 participants