-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to pytest-docker
v1
#6547
Conversation
✅ Deploy Preview for meltano ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I updated the Poetry lock file using Poetry |
The version I used previously, `1.1.13`, had a bug that would set all updated entries under `[metadata.files]` to `[]`
@WillDaSilva this might help python-poetry/poetry#5988 (comment) |
@edgarrmondragon Thanks for the link. I had already cleared my Poetry cache before generating the lock file for 6ade6a7, yet unfortunately the problem remains. I've been able to reproduce locally. The same failures occur on main after updating the lock file, so it seems like we will have to put a max version restriction on one of the non-dev dependencies that
Or we can just get to the bottom of this, and fix whatever bug is causing this if it within our own code. |
Keeping When the tests are run in isolation, they do not error, regardless of whether I had Relevant changelog: https://github.com/maxcountryman/flask-login/blob/main/CHANGES.md#version-062 |
Codecov Report
@@ Coverage Diff @@
## main #6547 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 95 95
Lines 8349 8349
Branches 398 398
=======================================
Hits 8059 8059
Misses 227 227
Partials 63 63 Help us with your feedback. Take ten seconds to tell us how you rate us. |
@WillDaSilva can you enable the Windows x Python 3.10 tests on this PR to see if this fixes them? |
Co-authored-by: Edgar R. M. <edgarrm358@gmail.com>
I was planning to do that after this PR goes through, to avoid introducing errors to this one if something goes wrong. |
@WillDaSilva sounds good 👍 |
Closes #6496