feat: Add support for encrypted ssh keys #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugin/src/main/java/me/champeau/gradle/igp/internal/DefaultAuthentication.java
Outdated
Show resolved
Hide resolved
…thentication.java
|
Thanks for the PR. I don't think we need another method for this, we could simply add the encryption option to |
|
Can do. |
raghav-deepsource
force-pushed
the
add-encrypted-key-support
branch
from
a1a0b22
to
edc4de5
Compare
plugin/src/main/java/me/champeau/gradle/igp/internal/DefaultIncludeGitExtension.java
Outdated
Show resolved
Hide resolved
…cludeGitExtension.java
|
How does this look? |
|
Well, turns out this won't be enough for my use case... As one of the few people who uses an encrypted ed25519 key, which jgit can't support because jsch sadly does not support this new standard... |
Should be fixed by using an alternative dependency. See #28. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there's no way to use an encrypted key file for ssh authentication in the plugin, so I tried adding it in. I'm not sure how to test it, but it looked straightforward enough...