Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModalWithTabs] Fix console error for missing prop #360

Closed
luciob opened this issue Oct 24, 2023 · 1 comment · Fixed by #361
Closed

[ModalWithTabs] Fix console error for missing prop #360

luciob opened this issue Oct 24, 2023 · 1 comment · Fixed by #361
Assignees
Labels

Comments

@luciob
Copy link
Member

luciob commented Oct 24, 2023

ModalWithTabs component logs the following error in console.

  console.error
    Warning: Failed prop type: The prop `xs` of `Grid` can only be used together with the `item` prop.
        at Grid (/Users/luciob/Works/melfore/libraries/mosaic/node_modules/@mui/material/node/Grid/Grid.js:380:49)
        at ModalWithTabs (/Users/luciob/Works/melfore/libraries/mosaic/src/components/ModalWithTabs/index.tsx:37:3)
        at /Users/luciob/Works/melfore/libraries/mosaic/src/utils/hocs/localized.tsx:81:56
        at MosaicContextProvider (/Users/luciob/Works/melfore/libraries/mosaic/src/contexts/Mosaic.tsx:26:11)
        at WrapperComponent (/Users/luciob/Works/melfore/libraries/mosaic/node_modules/@cfaester/enzyme-adapter-react-18/dist/enzyme-adapter-utils/createMountWrapper.js:47:13)

      78 |           {children}
      79 |         </Grid>
    > 80 |         <Grid xs={12}>
         |         ^
      81 |           <Tabs data-cy={dataCy} labelList={labelList} color={color} orientation={autoOrientation} style={style} />
      82 |         </Grid>
      83 |       </Grid>

Reproduce the error with npm run test.

CrisGrud pushed a commit that referenced this issue Oct 25, 2023
@CrisGrud CrisGrud linked a pull request Oct 25, 2023 that will close this issue
luciob pushed a commit that referenced this issue Oct 25, 2023
## [9.8.1](v9.8.0...v9.8.1) (2023-10-25)

### Bug Fixes

* 🐛 [ModalWithTabs] fixed grid error ([e90cb53](e90cb53)), closes [#360](#360)
@luciob
Copy link
Member Author

luciob commented Oct 25, 2023

🎉 This issue has been resolved in version 9.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants