Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InputNumber] Min value possible issue when deleting field #316

Closed
luciob opened this issue Aug 23, 2023 · 2 comments · Fixed by #318
Closed

[InputNumber] Min value possible issue when deleting field #316

luciob opened this issue Aug 23, 2023 · 2 comments · Fixed by #318
Assignees
@CrisGrud
Labels
released

Comments

@luciob
Copy link
Member

luciob commented Aug 23, 2023

Take the Min Max example story for InputNumber component.

<InputNumber
  dataCy="input-number"
  label="Label"
  maxValue={10}
  minValue={1}
  onChange={function noRefCheck(){}}
  value={5}
/>

Check if when removing the value the min value remains or if user is able to write any number.
In case not possible, find a way to let users reset the field value.

CC: @erosval
@luciob
Copy link
Member Author

luciob commented Aug 24, 2023

See also: mui/material-ui#19154 (comment)

CrisGrud pushed a commit that referenced this issue Aug 24, 2023
fix: 🐛 [InputNumber] Fixed number validation
cb1b7f3 
✅ Closes: #316
CrisGrud pushed a commit that referenced this issue Aug 24, 2023
fix: 🐛 [Input Number] Fixed wrong characters insert
3b13b62 
✅ Closes: #316
@CrisGrud CrisGrud linked a pull request Aug 24, 2023 that will close this issue
[Input Number] Min value fixed #318
Merged
@CrisGrud CrisGrud mentioned this issue Aug 24, 2023
Merged
CrisGrud pushed a commit that referenced this issue Aug 25, 2023
refactor: 💡 [Input Number] added a feature
eccab4f 
✅ Closes: #316
luciob pushed a commit that referenced this issue Aug 25, 2023
@semantic-release-bot
chore(release): 8.3.1 [skip ci]
c3895a9 
## [8.3.1](v8.3.0...v8.3.1) (2023-08-25)

### Bug Fixes

* 🐛 [Input Number] Fixed wrong characters insert ([3b13b62](3b13b62)), closes [#316](#316)
* 🐛 [InputNumber] Fixed number validation ([cb1b7f3](cb1b7f3)), closes [#316](#316)
@luciob
Copy link
Member Author

luciob commented Aug 25, 2023

🎉 This issue has been resolved in version 8.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CrisGrud CrisGrud

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Input Number] Min value fixed melfore/mosaic
2 participants
@luciob @CrisGrud